Remove all CPU limits
Closed this issue · 4 comments
Describe the bug
You shouldn't be setting CPU limits: https://home.robusta.dev/blog/stop-using-cpu-limits
Also, helm currently has a regression that prevents you from nulling out a value from a parent chart so we can't remove CPU limits from the config in our values.yaml we specify
Its a bad practice in the first place. Could just drop all the CPU limits you've configured in this chart?
Can you please specify in which pods / deployments the issue occurs, for me the websevers only have limits on the memory, but not on cpu.
Perhaps you're not specifying the requests and limits yourself in the values file. I think that the current requests and limits in the chart are quite sensible, and provide a good starting point.
@gschuurman you can do a code search and see all of them theres a bunch: https://github.com/search?q=repo%3Aacryldata%2Fdatahub-helm+cpu%3A&type=code
This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io
This issue was closed because it has been inactive for 30 days since being marked as stale.