`excl-*` config values are missing when running the action
Enrico2 opened this issue · 2 comments
Enrico2 commented
Do the checklist before filing an issue:
- Is this related to the
actions-rs
Actions?
If you think it's a problem related to Github Actions in general, use GitHub Community forum instead: https://github.community - You've read the Contributing section about bugs reporting: https://github.com/actions-rs/.github/blob/master/CONTRIBUTING.md#reporting-bugs
- Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.
Description
My .github/actions-rs/grcov.yml
contains:
branch: true
ignore-not-existing: true
llvm: true
filter: covered
output-type: lcov
output-path: ./lcov.info
excl-line: "#\\[derive\\("
excl-br-line: "#\\[derive\\("
excl-start: "mod tests \\{"
excl-br-start: "mod tests \\{"
The debug statement when the action is run prints:
##[debug]User configuration: {"branch":true,"ignoreNotExisting":true,"llvm":true,"filter":"covered","outputType":"lcov","outputPath":"./lcov.info"}
It looks like the excl*
config values are missing.
Workflow code
Action output
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: 0
RUSTFLAGS: -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests
RUSTDOCFLAGS: -Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests
##[debug]User configuration: {"branch":true,"ignoreNotExisting":true,"llvm":true,"filter":"covered","outputType":"lcov","outputPath":"./lcov.info"}
::group::Searching for coverage files
Searching for coverage files
Found project crates: apollo-query-planner,graphql-parser
##[debug]Creating an archive with coverage files at /tmp/coverage-wmwe4iwq1z.zip
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/apollo_query_planner-48cd324783e6f8e1.gcno
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/apollo_query_planner-9a2d2ac00302e9ac.gcda
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/apollo_query_planner-9a2d2ac00302e9ac.gcno
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-13f552932c4a8288.gcda
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-13f552932c4a8288.gcno
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-989eb3afebc0a136.gcda
Archiving coverage file: /home/runner/work/rust/rust/target/debug/deps/graphql_parser-989eb3afebc0a136.gcno
Coverage files archive was created at the /tmp/coverage-wmwe4iwq1z.zip
::endgroup::
::group::Execute grcov
Execute grcov
/usr/share/rust/.cargo/bin/grcov /tmp/coverage-wmwe4iwq1z.zip --branch --ignore-not-existing --llvm --commit-sha 8a2f4ca73c9529274661fcc710573c49b7647409 --filter covered --output-path /home/runner/work/rust/rust/lcov.info --output-type lcov --service-name Code Coverage --source-dir /home/runner/work/rust/rust
::endgroup::
Generated coverage report at /home/runner/work/rust/rust/lcov.info
::set-output name=report::/home/runner/work/rust/rust/lcov.info
##[debug]steps.coverage.outputs.report='/home/runner/work/rust/rust/lcov.info'
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Run actions-rs/grcov@v0.1
Expected behavior
I believe the result of those options not showing up is that some lines are detected as not covered, e.g. all of the lines in the FetchGroup struct here: https://codecov.io/gh/apollographql/rust/src/8a2f4ca73c9529274661fcc710573c49b7647409/query-planner/src/groups.rs
Enrico2 commented
Yes seems like it.