actions/languageservices

Pull request activity type missing `(de)milestoned`

flying-sheep opened this issue · 0 comments

flying-sheep commented

Describe the bug
Valid pull request event types include milestoned and demilestoned (like issue event types), but the schema doesn’t show them:

languageservices/workflow-parser/src/workflow-v1.0.json

Lines 821 to 841 in 4ddbbc9

"pull-request-activity-type": {
"allowed-values": [
"assigned",
"unassigned",
"labeled",
"unlabeled",
"opened",
"edited",
"closed",
"reopened",
"synchronize",
"converted_to_draft",
"ready_for_review",
"locked",
"unlocked",
"review_requested",
"review_request_removed",
"auto_merge_enabled",
"auto_merge_disabled"
]
},

To Reproduce
Steps to reproduce the behavior:

  1. Try to validate your valid workflow (it runs as expected when adding or removing a milestone)
  2. see validation errors for the milestoned and demilestoned event

Expected behavior
milestoned and demilestoned are accepted as valid

Screenshots
grafik

Package/Area

  • Expressions
  • Workflow Parser
  • Language Service
  • Language Server

Package Version
v0.3.6

Additional context
The GitHub docs are also inconsistent here: The webhook docs list those event types but the workflow syntax docs don’t.

A said: It’s definitely valid. Using the event types works, part of the docs mention the event types, and clearly adding milestones to a PR is something you can do both with the API and the web UI.