Infrastructure: v30.3.0 has an outward breaking change from v30.0.0
Closed this issue · 5 comments
In updating from v30.0.0 to v30.3.0 I needed to update some of our local code in the GSF. There is an outward breaking change in that the MultiStepper does not take the Acts::MixtureReductionMethod argument anymore, see e.g. the example method. I'm not sure what the release schedule/plan is but in principle v30.3.0 should have been marked as v31 due to this outward breaking change.
See the GsfFitterFunction.cpp file in the diff here. There is apparently an outward breaking change confirmed by having to compile our own locally developed code that depends on Acts with v30.3.0.
https://github.com/acts-project/acts/compare/v30.3.0..v30.0.0
Looks to me like you're right, I believe we failed to catch this.
/cc @benjaminhuth
Not a big change at all but I figured I'd mention it in case it was missed or unintended etc.
I think it's this PR: #2413
Would it help if I revert this PR in a patch release?
No worries at all, it is an easy fix so don't worry about a patch release. I just wanted to bring it to your attention
Ah yeah, I just thought about the Acts::Propagator interface and forgot the multistepper... Would be great to have an automatic test somehow...
@paulgessinger couldn't we run a diff over the doxygen or so? because this should be only built for the public interface, right?