ada-url/ada-python

Allow `pip install --no-binary` to work

bbayles opened this issue · 1 comments

Noted in #46:

pip install ada_url --no-binary ada_url will fail (on both Linux and Windows) because of the absence of ada.o

We would need to move the step that builds ada.o into the python -m build step. I looked into doing previously, but couldn't figure out a portable method.

use sources=['ada_url/ada.cpp'] (docs: https://setuptools.pypa.io/en/latest/userguide/ext_modules.html, https://cffi.readthedocs.io/en/stable/cdef.html#ffibuilder-set-source-preparing-out-of-line-modules) will not pass the CI.

Why It passes locally: local gcc version is 13, which defaults to -std=gnu++17.
But I don't know how to set different std for C and CPP.

Attachment: local-log.txt