[PGO] [nodejs] Do not make the compilation fail when PGO is used
Closed this issue · 1 comments
ptr1337 commented
Version
latest
Platform
Linux
What steps will reproduce the bug?
Compile nodejs with PGO:
--enable-pgo-generate
make test
--enable-pgo-use
How often does it reproduce? Is there a required condition?
100%
What is the expected behavior?
Successful compilation with PGO
What do you see instead?
Compilation is failing due -Werror=coverage-mismatch.
This warning should be maybe converted to a warning instead of an error.
Additional information
No response
lemire commented
It might be entirely reasonable for Node.js to pass on the -Wno-error=coverage-mismatch when the flag --enable-pgo-use is enabled, but that is a Node.js issue. The flag --enable-pgo-use is not part of the ada library.
The ada library is built using a standard CMake setup. Node.js uses its own build system (gyp) and the flag --enable-pgo-use is a custom flag.
I am closing the issue. The issue that you encounter, @ptr1337, is not specific to ada.