adafruit/Adafruit_CircuitPython_Display_Text

Tabs are ignored in `label` and `bitmap_label`

kmatch98 opened this issue · 5 comments

kmatch98 commented

Currently, all tabs '\n' are ignored in both label and bitmap_label.

lesamouraipourpre commented

That could be a challenge to define what a tab is. Do you define it as a fixed number of pixels, eg 25px, or do you define it based on the width of a character, eg 8 spaces. As a programmer, I would go with 4 spaces.

Also, how would it behave if the text is not left anchored?

jposada202020 commented

Agree with lesamouraipourpre, at the end of the day the 4 spaces will get translated to pixels in the library according to the Font used

  • 👍1
jposada202020 commented

@kmatch98 @FoamyGuy if you are not currently wrking at this I can take a look tonight. Let me know. :)

FoamyGuy commented

@jposada202020 I'd say go for it. Thank you! I'm going to test out the bitmap_label alignment PR next when I get back to it. This was a bit lower down the list for me, so am happy to have you take it on if you are willing to.

  • 👍1
FoamyGuy commented

resolved by #132