Library uses short argument names
Closed this issue · 6 comments
pylint suggests using argument names with at least 3 letters. This library uses argument names of shorter length, and while these warnings have been disabled for now, they should be considered for renaming. This may require the rework of Learn Guides and other references to code snippets.
I'm not aware of any learn guides using this, but it would make sense to add _pin to most of the names.
When I added the V2 support, I added _pin where it wouldn't break compatibility, so most of this is now done.
Does it make sense to close this now then?
or now with 9.0 just released? Seems most of this was cleaned up by Melissa in this commit a long time ago.
The only remaining disables I see are here:
@makermelissa are these compatibility breaking? Not sure if you had used examples or Learn Guides to benchmark that. I'm also fine with say this is good for now if changing these couple isn't advisable.
It's also worth mentioning that with the current discussion around switching to the ruff linter and formatter, this would also be affected (or possibly ignored).
@makermelissa are these compatibility breaking? Not sure if you had used examples or Learn Guides to benchmark that. I'm also fine with say this is good for now if changing these couple isn't advisable.
Possibly. It depends on whether somebody has used these as a keyword argument. I'm not aware of any code I made that did theat, but I can't vouch for other folks.