QTPy Memory Error

Question

QTPy Memory Error

smithj33 opened this issue 3 years ago · 16 comments

Issue:
With CircuitPython 7.3.2 and the latest libraries, the TMP117 cannot be used with the QTPy due to a memory allocation error.

Resolution:
Roll back to CircuitPython 6.3.0 and the TMP117 version 6 library.

I know the QTPy has limited memory, but I would expect this would still work with CP7.

Thanks

Answer 1 · 2022-08-01T03:41:23.000Z

CPy tends to use more RAM over time... really best option is to update your QT Py to an RP2040 since it has 10x the RAM!

Answer 2 · 2022-08-01T04:17:34.000Z

Thanks. I just swapped the TP117 out for an SHT40 and it works with CPy7 and the QTPy. Appears the TP117 is just a more complex sensor as the library is almost twice as large with a lot of functionality built in.

Answer 3 · 2022-08-01T18:15:18.000Z

awesome, thank you
@evaherrada please add a note for this library that it may not work on low-ram boards such as SAMD21's

Answer 4 · 2022-08-01T19:23:34.000Z

We could also try and optimize this library. I suspect its RAM used could be reduced by trimming functionality or simplifying APIs.

Answer 5 · 2022-08-01T19:25:01.000Z

we could but thats unlikely to happen soon, better to warn folks until that magical day arrives

Answer 6 · 2022-08-01T20:16:15.000Z

Suggestions for making more compact:

_*_MODE values can be const(). They are just binary integers.
_convert_to_integer is used only to convert the serial number into a long int. Remove this and just return the serial number as a bytearray. Using a longint causes issues on SAMD21 builds anyway.
.temperature_offset, .high_limit, and .low_limit all have virtually identical code in their setters: range check of -256 to 255, and same scaled value calculation. Refactor this. Also these exceptions should really be ValueError, not AttributeError.
(EDIT: ADDED) AverageCount.AVERAGE_<n>X* uses the word "average" redundantly. Shorter strings would be AverageCount.X_<n>. Same for MeasurementDelay.DELAY_*.

Answer 7 · 2022-08-01T20:19:53.000Z

Also, class CV is duplicated in a bunch of libraries, so it will not be shared when multiple libraries are loaded. This could be factored out into its own library or added to adafruit_register.

Answer 8 · 2022-08-01T21:35:07.000Z

@Neradoc do you want to try improving the size of this library?

Answer 9 · 2023-01-24T17:47:52.000Z

Hello there. I could work on this if needed. @Neradoc, let me know if that is ok with you!. thanks :)

Answer 10 · 2023-01-24T18:21:48.000Z

Yes (I don't actually know why I was assigned to this).

Answer 11 · 2023-01-24T19:22:36.000Z

Will do thanks :)

Answer 12 · 2023-01-25T15:42:48.000Z

I include suggestions in #13. However, we still have te memory allocation problem. Path from here will be either:

Make a basic and advanced library as we did for the BME280 sensor https://github.com/adafruit/Adafruit_CircuitPython_BME280

or

Remove CV and make values instead the overhead of the class to create them as we do for most of the libraries. see https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH.

Either way, it would be a breaking change. Just a note, I have not done the test removing the CV class, so not sure of the result and we could end up doing solution 1.

So let me know with path do you prefer to go. Thanks @tannewt @dhalbert

Answer 13 · 2023-01-25T15:47:10.000Z

I agree with you about removing the CV stuff, which adds overhead and uses space. I would start with that first, and then we will need to update the examples and any Learn Guides.

Answer 14 · 2023-01-25T15:50:28.000Z

Will do thanks :)

Answer 15 · 2023-02-04T18:31:02.000Z

Just an update, removing the CV did not solve the problem. as you could see in 54887af. Thanks

Answer 16 · 2024-12-05T19:36:57.000Z

Hello, returning to this one, I did make it work with a QT PY, There is the PR mentioned above, and I refactored the whole library in a personal Repo, let me know If a PR is needed I can go both ways.