adafruit/Adafruit_EPD

FeatherWingTest drawBMP setting location not working

caternuson opened this issue · 8 comments

caternuson commented

Re this thread:
https://forums.adafruit.com/viewtopic.php?f=57&t=159450

Maybe add the x,y offsets here?

Adafruit_EPD/examples/FeatherWingTest/FeatherWingTest.ino

Line 234 in 8059218

epd.writePixel(col, row, c);

caternuson commented

@makermelissa does the FeatherWingTest example in this repo need updating as well? Or maybe just removed in favor of something in the ImageReader repo?

makermelissa commented

I think probably removed in favor of the ImageReader repo. I think the EInkBreakout example in the ImageReader repo should be able to do feathers as well, but I'd have to double check that.

ladyada commented

yah plz remove here - imagereader is our canonical image-to-display library!

caternuson commented

ok @makermelissa can you make that PR? since it sounds like maybe you want to test some things.

makermelissa commented

Yes, should be easy enough.

  • 👍1
makermelissa commented

Ok, after looking at it, I'm going to make 2 PRs:

  1. Add a new EInkFeatherWing test to ImageReader so the breakout one doesn't get messy.
  2. Remove any examples in this library that draw bitmaps.
ladyada commented

sounds like a good plan!