adamjgrant/kickstart

Undefined heading mixins in Rails

Closed this issue · 6 comments

anthonylebrun commented

First off, really great framework. I really appreciate the thought you've put into it and it all just makes a lot of sense to me. One little oopsie I've come into:

I installed and set up the gem as prescribed here and mixins seem to work generally with the exception of the decoupled heading mixins.

h1
  @include md-heading()

(I'm using the Sass syntax)

At which point I would get a ActionView::Template::Error (Undefined mixin 'md-heading'.)

adamjgrant commented

I think you want

h1
  @include heading_md();

And thanks for the kind words!

anthonylebrun commented

Oh awesome! I guess the docs are just a bit behind:

http://getkickstart.com/docs/3.x/ui/typography/

If those are hosted on a public repo I'd be happy to create a pull request for you.

adamjgrant commented

Oh shoot! I didn't notice this. I'll fix this now...

On Mon, Apr 20, 2015 at 5:22 PM Pierre Lebrun notifications@github.com
wrote:

Oh awesome! I guess the docs are just a bit behind:

http://getkickstart.com/docs/3.x/ui/typography/

If those are hosted on a public repo I'd be happy to create a pull request
for you.

—
Reply to this email directly or view it on GitHub
#177 (comment)
.

adamjgrant commented

Okay, should be fixed now.

anthonylebrun commented

I noticed! Although I think you meant heading_md() rather than heading-md()?

I prefer the heading-md naming convention though, it's more consistent with your other mixins.

adamjgrant commented

They should both work, actually. It's a Sass thing.

On Tue, Apr 21, 2015 at 10:37 AM Pierre Lebrun notifications@github.com
wrote:

I noticed! Although I think you meant heading_md() rather than
heading-md()?

I prefer the heading-md naming convention though, it's more consistent
with your other mixins.

—
Reply to this email directly or view it on GitHub
#177 (comment)
.