adamjgrant/kickstart

Sass::SyntaxError Undefined variable: "$breakpoint-1px".

ccastillop opened this issue · 4 comments

After using st like:

.main-nav {
  @include navbar($layout: 'fluid-fixed');
}

pops up Sass::SyntaxError Undefined variable: "$breakpoint-1px".

Instead, using st like:

.main-nav {
  @include navbar();
}

works fine.

Rails 4.2.0, kickstart_rails (3.1.2), sass (3.4.14)

Thanks for reporting this. But I don't seen any difference between the two code blocks. What was the code that worked?

Sorry the mistake. I've just corrected the bug.
Adding $layout: 'fluid-fixed' or $background-color: #333 rises the error. Without arguments navbar() works fine.

Ok,
Browsing the code I found this line: /lib-core/sass/core/components/_navbar.sass#L26 similar to $breakpoint - 1px. Notice the white space between -.

Browsing locally the gem kickstart_rails-3.1.2 I notice this line very similar but without the white spaces: ~/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/kickstart_rails-3.1.2/app/assets/stylesheets/core/components/_navbar.sass Line 26

> li
  ul[role=button], > [role=button], &.navbar-title button[role="button"]
    @media screen and (max-width: #{$breakpoint-1px})
      margin:
        left: 0
        right: 0

Adding manually the white spaces works. Why these spaces were removed?

Good find! Yes, it definitely looks like this was fixed in the main repo,
but wasn't pushed into the rails gem. I'm mobile at the moment so I can't
fix this just yet, but I'll make sure this is taken care of as soon as I
can.
Le Mon, Jun 1, 2015 à 11:29 AM, Cristiam Castillo notifications@github.com
a écrit :

Ok,
Browsing the code I found this line:
/lib-core/sass/core/components/_navbar.sass#L26 similar to $breakpoint -
1px. Notice the white space between -.

Browsing locally the gem kickstart_rails-3.1.2 I notice this line very
similar but without the white spaces:
~/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/kickstart_rails-3.1.2/app/assets/stylesheets/core/components/_navbar.sass
Line 26

li
ul[role=button], > [role=button], &.navbar-title button[role="button"]
@media screen and (max-width: #{$breakpoint-1px})
margin:
left: 0
right: 0

Adding manually the white spaces works. Why these spaces where removed?


Reply to this email directly or view it on GitHub
#179 (comment)
.

Adam Grant