Error with gulp-sass compiling
tonkoshkurik opened this issue · 15 comments
I can not understand what the problem is.
When compile sass via gulp receive here such error
Error in plugin 'sass'
Message:
app/sass/core/_direct-apply.sass
Error: Invalid CSS after "...tooltip-classes": expected "{", was ";"
on line 191 of app/sass/core/_direct-apply.sass@mixin tooltip-classes;
-------^
Hmm, I haven't been able to reproduce this. Can you show me your package.json?
Of course
{
"name": "html",
"version": "1.0.0",
"description": "",
"main": "index.js",
"dependencies": {
"kickstart-node": "^3.0.75"
},
"devDependencies": {
"gulp": "^3.9.1",
"gulp-autoprefixer": "^3.1.0",
"gulp-connect": "^4.0.0",
"gulp-livereload": "^3.8.1",
"gulp-minify-css": "^1.2.4",
"gulp-sass": "^2.3.1",
"opn": "^4.0.2"
},
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
"license": "ISC"
}
Hmm, I wonder if this is an issue with the npm version of kickstart, which
I haven't maintained well.
On Mon, Jun 6, 2016 at 10:57 AM tonkoshkurik notifications@github.com
wrote:
Of course
{
"name": "html",
"version": "1.0.0",
"description": "",
"main": "index.js",
"dependencies": {
"kickstart-node": "^3.0.75"
},
"devDependencies": {
"gulp": "^3.9.1",
"gulp-autoprefixer": "^3.1.0",
"gulp-connect": "^4.0.0",
"gulp-livereload": "^3.8.1",
"gulp-minify-css": "^1.2.4",
"gulp-sass": "^2.3.1",
"opn": "^4.0.2"
},
"scripts": {
"test": "echo "Error: no test specified" && exit 1"
},
"author": "",
"license": "ISC"
}—
You are receiving this because you commented.Reply to this email directly, view it on GitHub
#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AATj7tbJhqcvxdD4dThOM429W5RK7Udfks5qJF9qgaJpZM4IvI-j
.Adam Grant
When I do a gulp setup I usually do it from here http://getkickstart.com/docs/3.x/#gulp
And end up with a package.json like this:
{
"name": "kickstart-node",
"version": "3.0.76",
"description": "A front-end library for clean HTML and fast performance",
"keywords": [
"CoffeeScript",
"Jade",
"CSS",
"JS",
"Node",
"Gulp"
],
"homepage": "http://getkickstart.com",
"bugs": "https://github.com/adamjgrant/kickstart/issues",
"author": "Adam Kochanowicz",
"repository": {
"type": "git",
"url": "git://github.com/adamjgrant/kickstart.git"
},
"browser": {},
"browserify": {
"transform": [
"coffeeify",
"browserify-shim"
]
},
"browserify-shim": {
"makePromise": "./node_modules/when/lib/makePromise"
},
"devDependencies": {
"browser-sync": "^1.3.6",
"browserify": "^6.2.0",
"browserify-shim": "^3.7.0",
"chai": "^1.9.1",
"coffeeify": "^0.7.0",
"css-purge": "^1.1.1",
"flexbox-grid": "^1.0.0",
"gulp": "^3.8.6",
"gulp-autoprefixer": "0.0.10",
"gulp-cached": "^1.0.1",
"gulp-coffee": "^2.1.1",
"gulp-concat": "^2.4.0",
"gulp-connect": "^2.0.6",
"gulp-css-purge": "^1.0.0",
"gulp-derequire": "^1.0.0",
"gulp-expect-file": "0.0.7",
"gulp-if": "^1.2.4",
"gulp-imagemin": "^1.0.1",
"gulp-jade": "^0.6.1",
"gulp-minify-css": "^0.3.8",
"gulp-mocha": "^1.0.0",
"gulp-mocha-phantomjs": "^0.10.1",
"gulp-mustache": "^0.4.0",
"gulp-newer": "^0.3.0",
"gulp-notify": "^1.5.0",
"gulp-rename": "^1.2.0",
"gulp-ruby-sass": "^0.7.1",
"gulp-todos": "^0.1.0",
"gulp-uglify": "^1.0.1",
"gulp-util": "^3.0.1",
"gulp-watch": "^0.6.8",
"highlight.js": "^8.2.0",
"markdown-js": "0.0.3",
"mocha": "^1.21.4",
"normalize.css": "^3.0.1",
"pretty-hrtime": "^0.2.1",
"require-dir": "^0.1.0",
"vinyl-source-stream": "^0.1.1",
"watchify": "^2.1.1",
"when": "^3.4.4"
}
}
I wonder if maybe your project is using a different version of sass than kickstart-node does. Can you try upgrading to Sass 3.4 or above?
Strange that it is raising an error expecting SCSS instead of Sass syntax.
I'm having the same problem, also the paths for the imports in node_modules/kickstart-node/lib-core/sass/themes/default/theme.sass aren't correct. They should be ../../core/_normalize. If I fix this I get the same scss error.
Joe, for the paths, I believe it should be okay with the double dot
relative directory prefixes. Sass looks through an index of known
directories before it interprets the path literally. I also wrote it this
way because I noticed this causes issues when those files are moved around,
such as in a Rails project.
On Tue, Jun 14, 2016 at 8:59 AM Joe Kolba notifications@github.com wrote:
I'm having the same problem, also the paths for the imports in
node_modules/kickstart-node/lib-core/sass/themes/default/theme.sass aren't
correct. They should be ../../core/_normalize. If I fix this I get the same
scss error.—
You are receiving this because you commented.Reply to this email directly, view it on GitHub
#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AATj7m0FsdKpndWTx4zYy7lH9yeCfo7qks5qLs_bgaJpZM4IvI-j
.Adam Grant
Since we are getting "File to import not found or unreadable: core/_normalize". I would imagine it's probably our loader that isn't working as expected. We are using the following project:
https://github.com/AngularClass/angular2-webpack-starter
I am new to sass, not sure if you have any ideas why it isn't loading sass files correctly. Do you have any plans to offer a scss build?
we had to remove the following line in order for it to run:
kickstart-node/lib-core/sass/core/_direct-apply.sass (line 192, column 8)
Thanks for looking into this, Joe. I think that should be fine. You'll just
lose some "directly applied" classes for certain things. Without looking I
believe these are things like .button and some base styling. If you run
into any issues, you may want to take a peek into that file to see if that
is the cause.
I apologize I don't have the bandwidth to jump in more. I've got my
distance wedding in a couple weeks and am swamped with preparation, but I'm
eager to get back on Kickstart when I return.
On Tue, Jun 14, 2016 at 1:08 PM Joe Kolba notifications@github.com wrote:
we had to remove the following line in order for it to run:
kickstart-node/lib-core/sass/core/_direct-apply.sass (line 192, column 8)
—
You are receiving this because you commented.Reply to this email directly, view it on GitHub
#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AATj7r426MGFq3bJJQ_dPMYKldwE0IzHks5qLwpZgaJpZM4IvI-j
.Adam Grant
I reproduce the error with the latest node-sass (v3.8.0) that uses libsass v3.3.6.
When I comment out this line in _direct-apply.sass it works fine.
// =tooltip-classes
Hi all.
Thanks for diagnosing this, this helps a lot.
Fortunately, v4 will do away with a lot of this nonsense. As for v3, I'm
currently on a hiatus from Kickstart as I recover from my wedding planning
and am getting started with a renovation. But rest assured these are on my
list and I will return.
On Fri, Aug 12, 2016 at 7:39 AM piglovesyou notifications@github.com
wrote:
I reproduce the error with the latest node-sass (v3.8.0) that uses libsass
v3.3.6.When I comment out this line in _direct-apply.sass it works fine.
// =tooltip-classes
—
You are receiving this because you commented.Reply to this email directly, view it on GitHub
#187 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATj7svCHGLQpkPtcSb_UeJarFwXuwoeks5qfIWGgaJpZM4IvI-j
.Adam Grant
Good to hear that. I found a PR for it by the way. And congrats for the wedding! 💐
I can stil reproduce this issue with kickstarter-node 3.0.75 and node-sass 4.5.3 (running on node v6.11.4).
are there any plans to fix this issue (e.g. merge the PR mentioned above?)