Not working on 1.8.7

[carr]

Hello,
this doesn't seem to be working on Ruby 1.8.7, it breaks in the smtp_tls.rb file.

I created a fix that looks like this, just replace line 9.

if RUBY_VERSION=="1.8.6"
    check_auth_args(user, secret, authtype) if (user or secret)
else
    check_auth_args(user, secret) if (user or secret)
end

[harley]

Wow I was going to report the same thing. Should have looked here first :(
Ruby 1.8.7+ and Rails 2.3+ already support tls so an alternative is to include this plugin only if RUBY_VERSION=="1.8.6" (specified in environment.rb) and specify smtp settings there instead (with :enable_starttls_auto => true). But your fix is definitely the simplest!
Thanks

[carr]

no problem. although I should've probably forked it

[brentlintner]

Should of looked here first as well! I posted on the google group about modifying it to do pretty much what you said harleyttd...

If its worth anything its here.
http://groups.google.com/group/heroku/browse_thread/thread/995ae2093d8f2027#

Cheers,

brent

[lukaso]

This is a slightly cleaner fix, which I found in the bluecloth and pg gems:

    if user or secret
        if self.method( :check_auth_args ).arity == 3
            check_auth_args( user, secret, authtype )
        else
            check_auth_args( user, secret )
        end
    end

Much luck!

-Lukas

[mokolabs]

+1 for freerobby's fork.

Can we get that pulled and merged?

[jaredbeck]

I had the same problem .. carr's fix worked for me. If this isn't going to be fixed then maybe heroku's help docs should be updated, or maybe the docs shouldn't refer to this plugin?