adamwulf/JotUI

scissorRect is clipping points even through their pointSize would overlap the scissorRect

adamwulf opened this issue · 1 comments

The scissor rect clips points according to their center, not according to their center + pointSize. This can lead to some strange artifacts during undo/redo or when changing the rotation of the highlighter which causes a re-render of all strokes around the start point.

simulator screen shot sep 8 2016 2 42 42 am

Possible solutions:

  1. don't use scissor test at all, which is what I've done for now to keep rendering correct at the expense of speed, or
  2. use quads instead of points, which will raise point memory by 4x, which might be ok

This recent commit simply turns off scissor test altogether to err on the side of render accuracy over speed. To fix would probably require quads instead of points, which would be at least a tradeoff of memory and may affect performance elsewhere as well.