Do not always regenerate site; crashes on Heroku
stomar opened this issue · 3 comments
As far as I understand, rack-jekyll now always (re)generates the site (see 1088b1b). This crashes on Heroku (read-only file system)!
Besides, also users who do not deploy on Heroku should have the option to avoid regeneration; it's very slow for a big site, so in this case deploying a previously generated site might be the better option.
The default behaviour should IMO be to not regenerate an already existing _site
dir; this is the behaviour of the current (but outdated) RubyGems release, 0.4.1.
Note that we failed to switch www.ruby-lang.org to Jekyll 2 with both of the following approaches:
- use rack-jekyll from RubyGems: in combination with Jekyll 2 this forces a very old version of rack-jekyll (0.3.5, because of dependencies); this version is buggy and truncates files due to wrong Content-Length headers
- use the development branch version from GitHub: this version crashes on Heroku, because of the changed (re)generation behaviour
Please fix this issue and release a new version.
See also ruby/www.ruby-lang.org/issues/1073.
Currently we use a patched version of rack-jekyll 0.4.1 that has more liberal dependencies on Jekyll and rake, see my fork (stomar/rack-jekyll@d39334a, this backports the current version of rack-jekyll.gemspec
to version 0.4.1).
I would prefer switching back to official gem releases some time in the future, though.
Solved with 0.4.2.