adaoraul/rack-jekyll

rack version pinned to ~> 1.5

ConorSheehan1 opened this issue · 4 comments

ConorSheehan1 commented

For reference, I'm using rack-jekyll to test my site, following this gist

When I start my site with bundle exec jekyll server
My css folder is built from sass sources

But when I use Rack::Jekyll.new(force_build: true) it doesn't build css.

My tests pass with rack-jekyll 0.5.0. My problem is that I want to use rack >= 2.0.6, but rack-jekyll 0.5.0 depends on rack ~> 1.5, so in order to upgrade rack, I have to actually downgrade rack-jekyll to 0.3.5, and that's where my issue lies.

System info

  • ruby 2.4.4
  • ubuntu 16.04
ConorSheehan1 commented

Gemfile

# frozen_string_literal: true

ruby '>= 2.3.0'

group :development, :test do
  gem 'rack', '>= 2.0.6'
  gem 'rack-jekyll', '0.5.0'
end

Error

Bundler could not find compatible versions for gem "rack":
  In Gemfile:
    rack (>= 2.0.6)

    rack-jekyll (= 0.5.0) was resolved to 0.5.0, which depends on
      rack (~> 1.5)
ConorSheehan1 commented

It looks like the fix is already on master.

Last release (0.5.0) had rack ~> 1.5, but master has rack >= 1.5 in the gemspec

Any chance you could make a new 0.5.x release?
I think that'd solve my whole issue because I could go to rack-jekyll 0.5.x behaviour with rack > 2.0.6

jmhooper commented

Bumping this. I'm getting an alert about a directory traversal vulnerability in Rack in the latest published version of this gem. It looks like that is fixed on master. Any chance we could get an update?

Ref: https://snyk.io/vuln/SNYK-RUBY-RACK-569066

  • 👀1
simi commented

@adaoraul hello, would it be possible to release new version supporting rack 2? Is there anything I can help with?

ref: rubygems/rubygems.github.io#75

  • 👍1