adaptlearning/adapt-contrib-vanilla

Drawer doesn't have a color defined

Closed this issue ยท 1 comments

Subject of the issue

In drawer.less, .drawer has a background-color defined but no color. Instead the color is inherited from body.

Expected behaviour

I'd expect .drawer to use color: @drawer-inverted. Typically all Adapt elements use the named variable for background-color and the invert for color. For example:

.notify__popup {
    background-color: @notify;
    color: @notify-inverted;
}

Actual behaviour

Drawer plugins need to define their own color otherwise this is inherited from body. The default Vanilla colors for @drawer and @font-color (used to set body color) are both dark, giving poor contrast. For consistency, all drawer plugins should inherit from drawer as standard and any plugin specific styles set in the drawer plugins (or theme).

drawer_color

๐ŸŽ‰ This issue has been resolved in version 9.6.13 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€