adaptlearning/adapt-contrib-vanilla

Errors when background layer is created by another plugin

swashbuck opened this issue ยท 1 comments

Subject of the issue

Currently, the "background" div layer is created by the Vanilla theme in addBackgroundLayer(). In some cases, the "background" layer div may be created by another plugin which causes addBackgroundLayer() to exit early without setting this.$background. The methods setBackgroundImage() and setBackgroundStyles() then try to reference this property and throw an error when it is not found.

I would suggest that we simply check for this.$background and exit early from those two methods if it's not found.

Your environment

  • Vanilla 9.8.1

Screenshots

themeView

๐ŸŽ‰ This issue has been resolved in version 9.8.4 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€