adaptlearning/adapt-contrib-vanilla

schema color variables aren't consistent with LESS color variables

Closed this issue ยท 1 comments

Subject of the issue

In a previous PR, the blue colour variable was updated in the LESS to meet AA color contrast but the hex codes referencing the blue in the schemas were not updated.

In the AAT, the schema color variables will always take precedence over the LESS variables so the old blue, #36CDE8 (pre-PR) still applies and fails colour contrast.

Expected behaviour

I'd suggest removing the default hex codes from the schemas as the default Vanilla colours are already applied via the CSS. Keeping the default values is another maintenance task when updating the colour variables - both maintaining Vanilla and creating bespoke themes. As per this issue, it's easily forgotten to update the schemas when amending the LESS variables.

๐ŸŽ‰ This issue has been resolved in version 9.10.0 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€