Is the Boxmenu item button margin needed?

[kirsty-hames]

Subject of the issue

Minor point, but, the margin-bottom attached to the .boxmenu-item__button-container creates inconsistent spacing around the item (1rem top/left/right and 2rem bottom). See screen shot below.

In addition, the .boxmenu-item__button-container margin is set by the @menu-item-progress-margin variable - not sure if this was an oversight when added.

Expected behaviour

As the .boxmenu-item__button-container is the last item on the menu item and there is already padding applied to the .boxmenu-item__inner, I don't see having margin here adds any value. This is something I typically remove when styling menus anyway.

[swashbuck]

Yep, agreed. I usually remove it, too.

[kirsty-hames]

Fixed by #467