adaptlearning/adapt_framework

Adapt.wait flush

danielghost opened this issue · 1 comments

Is the behaviour implemented via #2439 a good idea? Isn't it the responsibility of the plugin to ensure they call an Adapt.wait.end() if using an Adapt.wait.begin().

Flushing any open waits after 7 seconds means you can't intentionally block Adapt from loading, if required. For example, you may want to not call an end() and display an uncancellable notification to indicate an issue which should prevent a user from continuing. Currently the flush will end this, continue with the loading and eventually close any notifications regardless of the plugin functionality.

Yes, I agree.