Ability to modify XMLHttpRequest

Question

Ability to modify XMLHttpRequest

Closed this issue 10 years ago · 9 comments

It would be great if FluxThis.APIActionCreator could support a way of modifying the XMLHttpRequest either via createRequest or an alternate method. This would be quite helpful in adding additional headers needed for API authentication/versioning.

jhorwit2 commented 10 years ago

#80

mdhgriffiths commented 10 years ago

#81

Answer 1 · 2015-06-03T21:37:35.000Z

You thinking an object you would return in create request? Where the key is the header key? I like that.

That sounds easy enough to do. Ill knock it out this evening.

Answer 2 · 2015-06-03T21:40:38.000Z

Little clarification.

Ill add support for a 'headers' object in createRequest. If found, then we will set the headers to those key/value pairs.

Answer 3 · 2015-06-03T21:53:51.000Z

Sounds great, that's what I've already implemented on my own fork:
https://github.com/mdhgriffiths/fluxthis/commit/58dca715db5b443c20e3b322822c7108b636ff09

Answer 4 · 2015-06-03T21:57:29.000Z

Object.keys.... that's the method i couldn't think of for my PR (long day).

Btw, feel free to submit that PR! I'd gladly accept it instead of the one i submitted.

Answer 5 · 2015-06-03T22:00:40.000Z

Thanks, will submit PR after some changes/testing.

Answer 6 · 2015-06-03T22:03:02.000Z

Sounds good. I'll close mine out and wait for yours 👍

Answer 7 · 2015-06-03T22:36:57.000Z

Published to npm.