adeharo9/cpp-dotenv

Implement Testing

Opened this issue · 3 comments

Vi1i commented

I agree that testing needs to be done, I am happy to start it up.
There are some questions and some discussion on this that will need to be done I think.
Coming into this, I think we have to test functionality of the code and test the requirements/expectations of different support OSs.

I am not an expert here, but is using cmake testing with something like gtest an okay approach to the functionality in your eyes?
Do we also want to implement sometype of code linting and other checks on file?
For testing the OS side of things, we can do some docker magic for testing locally what we might want to test in CI before a push as well as setup some actions in GitHub to do this.

If we do add the docker part, we could later extend that area to include making packages for supported platforms.

To be completely sincere, gtest is the only testing framework I've used so far for testing on C++, so I think it is a good starting point. By the moment I would stick at simply testing the main functionalities of the library itself and make sure they work as intended; code linting and other functionality can be added once basic testing is sorted out on the latest release.

About the docker approach that you suggest, I think it is a great idea, both because it can be tested locally and because of the further extension possibilities that it provides.

Vi1i commented

Got it, I am find with gtest. Do you want it as a submodule or do you just want it handled in the cmake stuff?

Vi1i commented

I forked this weekend to start on it.