Minor improvements
Opened this issue · 0 comments
emiliyank commented
Hi Aditya Pratap Bhuyan!
Great job with this repo and the instructions to it. Here are just few suggestions how you can improve it:
- According to the readme the mysql password should be
password
while in the mysql-app-deployment.yaml file it is actually set to root. So in this file line 25 should be changed tovalue: password
- In the README at the last kubectl command is missing the apply - it should be kubectl apply -f deployments/mysql-app-service.yaml. And also the filename has typo in the repository, it is mysql-aap-service.yaml while it actually should be mysql-app-service.yaml