adityabisoi/json-hub

Add pre-commit hooks for linting

Closed this issue · 7 comments

ShauryaAg commented

Add pre-commit hooks that runs linting before committing the file.

Requirements:

  • Add .pre-commit-config.yml and define eslint and prettier hooks
  • Update the docs to install pre-commit hooks

Reference:

Samridhi-98 commented

I would like to work on this issue, will you please assign this to me.

ShauryaAg commented

@Samridhi-98 Sure. You can work on this one, but please note this issue's PR will only be merged after #68 is done.

Samridhi-98 commented

@Samridhi-98 Sure. You can work on this one, but please note this issue's PR will only be merged after #68 is done.

Okay, no problem.

  • 👍1
rithgan commented

Can i work on this if no one is assigned?

ShauryaAg commented

@rithgan Sure. You can take it. @Samridhi-98 is working on another issue.

rithgan commented

I have added the config file. There is a command on pre-commit which runs the prettier and eslint hooks on all the files. This will add the configuration as specified in prettier and eslint config files. Should I run this as well? This will cause indentation, whitespace like changes in all the files.