adobe/aem-boilerplate

decorateIcons implementation mixes sync and async

kptdobe opened this issue · 1 comments

kptdobe commented

Current decorateIcons implementation is misleading: while it works, after a call to decorateIcons, the DOM might not yet be up to date because of the async callback in the forEach.

bstopp commented

I think this is no longer an issue given the change icons are handled.

  • 👍1