Maven Build Warnings with latest filevault-package-maven-plugin
HitmanInWis opened this issue · 3 comments
HitmanInWis commented
Expected Behaviour
No maven build warnings.
Actual Behaviour
With the recent update to update filevault-package-maven-plugin
to version 1.3.6
in https://github.com/adobe/aem-project-archetype/pull/1177/files there are some warnings in the default maven build of an AEM project created from the archetype:
// ui.apps.structure package
[WARNING] ValidationViolation: Filter root's ancestor '/content/dam' is not covered by any of the specified dependencies nor a valid root. @ META-INF\vault\filter.xml, validator: jackrabbit-filter
[WARNING] ValidationViolation: Package of type 'MIXED' is legacy. Use one of the other types instead! @ META-INF\vault\properties.xml, validator: jackrabbit-packagetype
[WARNING] ValidationViolation: Found orphaned filter entries: entry with root '/apps', entry with root '/apps/mysite', entry with root '/apps/sling', entry with root '/apps/cq', entry with root '/apps/dam', entry with root '/apps/wcm', entry with root '/apps/msm', entry with root '/apps/settings', entry with root '/content/dam/mysite', validator: jackrabbit-filter
// ui.content package
[WARNING] ValidationViolation: Filter root's ancestor '/content/dam/mysite' is not covered by any of the specified dependencies nor a valid root. @ META-INF\vault\filter.xml, validator: jackrabbit-filter
[WARNING] ValidationViolation: Ancestor node '/content/dam/mysite' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules! @ jcr_root\content\dam\mysite\.content.xml, validator: jackrabbit-filter
// "all" package
[WARNING] Found duplicate file 'META-INF\vault\definition\.content.xml' from sources 'src\main\content\META-INF\vault\definition\.content.xml' and 'target\vault-work\META-INF\vault\definition\.content.xml'.
[WARNING] ValidationViolation: Found orphaned filter entries: entry with root '/apps/mysite-vendor-packages', validator: jackrabbit-filter
HitmanInWis commented
for the ui.apps.structure
items...
- should
/content/*
paths even be in here? - should we define the packageType as
application
since leaving it undefined gives this warning about "MIXED"? - should we simply ignore package validations, since this isnt actually a deployed package?
HitmanInWis commented
Regarding the "duplicate file" issue for the all
package.
The file in sources looks like this:
<jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0"
jcr:primaryType="vlt:PackageDefinition"
providerLink="https://github.com/adobe/aem-project-archetype/releases"
providerName="Adobe Systems Inc."
providerUrl="https://www.adobe.com"
testedWith="AEM 6.5">
</jcr:root>
The file created in the target
during build looks like this:
<jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0"
jcr:primaryType="vlt:PackageDefinition"
builtWith="Apache Jackrabbit FileVault - Package Maven Plugin 1.3.6"/>
Are either of these important to keep? If it doesnt really matter, can the "Adobe Systems Inc" one be removed from the src
directory?
HitmanInWis commented
Another warning in the build
[WARNING] Project is configured with outdated aemanalyser plugin version : 1.4.10
[WARNING] Please update to plugin version : 1.5.12
And if you update to 1.5.12
for aemanalyser
you get a new warning:
[INFO] Using detected SDK Version for analysis: com.adobe.aem:aem-sdk-api:2024.6.16799.20240614T073455Z-240600
[INFO] Using current project as content package: com.mysite:mysite.all:content-package:1.0.0-SNAPSHOT
[WARNING] Deprecated. Please refactor to use DefaultAclManager(String,String,boolean) instead