adobe/aio-cli-plugin-app

config files (.aio, .env) not available to templates for the "no login" case

shazron opened this issue · 1 comments

shazron commented

Description

As you can see here, the config is only imported after the templates are installed here, for the "no login" case:

aio-cli-plugin-app/src/commands/app/init.js

Lines 117 to 126 in f1088f1

await this.installTemplates({
useDefaultValues: flags.yes,
installNpm: flags.install,
installConfig: flags.login,
templates
})
// 5. import config - if any
if (flags.import) {
await this.importConsoleConfig(consoleConfig)

For the "logged in" case, the templates are installed after the console config is imported:

aio-cli-plugin-app/src/commands/app/init.js

Lines 157 to 164 in f1088f1

await this.importConsoleConfig(consoleConfig)
// 9. install templates
await this.installTemplates({
useDefaultValues: flags.yes,
installNpm: flags.install,
templates
})

We should be consistent in both cases.

The Fix

Import the console config (if available via flag for the no login case), before templates are installed.

Code affected:

aio-cli-plugin-app/src/commands/app/init.js

Lines 117 to 126 in f1088f1

await this.installTemplates({
useDefaultValues: flags.yes,
installNpm: flags.install,
installConfig: flags.login,
templates
})
// 5. import config - if any
if (flags.import) {
await this.importConsoleConfig(consoleConfig)