adobe/helix-data-embed

Return last modified date of a file in a header

Closed this issue · 4 comments

dominique-pfister commented

In order to detect changes to a file, it would be helpful if data-embed would return the last modified date of that file, e.g. in the Last-Modified HTTP response header.

This feature would particularly help in solving adobe/theblog#550

trieloff commented

Sounds reasonable.

  • 👍2
dominique-pfister commented

doesn't getWorkbook() return the last modified date?
https://github.com/adobe/helix-data-embed/blob/master/src/matchers/excel.js#L31

I don't think so: getWorkbook() just creates an instance of Workbook, adding a reference to OneDrive and the coordinates of the workbook:
https://github.com/adobe/helix-onedrive-support/blob/master/src/Workbook.js#L21-L27

trieloff commented

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀