adobe/helix-static

Cleanup Code

tripodsan opened this issue ยท 2 comments

the code has some leftovers that we should cleanup:

  • remove staticBase()

    helix-static/src/index.js

    Lines 293 to 296 in 8cac0a0

    function staticBase(owner, repo, entry, ref, strain = 'default') {
    // todo: is this still needed?
    return `__HLX/${owner}/${repo}/${strain}/${ref}/${entry}/DIST__`;
    }
  • remove plain parameter
  • remove strain parameter
  • decide path vs entry parameter (I would stick to path)

@trieloff WDYT?

I'll tackle this.

๐ŸŽ‰ This issue has been resolved in version 1.5.0 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€