adobe/helix-static

static should not fallback to master branch

Opened this issue · 2 comments

kptdobe commented

See https://github.com/adobe/helix-static/blob/master/src/static.js#L75

Required for adobe/helix-pages#531: ref might be undetermined when requesting helix-static (default branch must be used). helix-static must then:

  • allow ref parameter to be omitted
  • if this is the case, determine the ref (default branch) - should be responsibility of adobe/helix-resolve-git-ref. See adobe/helix-resolve-git-ref#287.

Requires adobe/helix-resolve-git-ref/issues/299 for simplicity of the change.

trieloff commented

Static is never called directly, so this is probably not a blocker

kptdobe commented

I think I (almost) agree. I am currently writing tests for the various overrides we may have...
I still found those direct requests to static: