adobe/leonardo

Returning white when darker colors should be returned

Closed this issue · 0 comments

Description

On certain hues, Leonardo is returning white as the newColors when it should be returning darker versions of the variable color.

This happens when using a blue variable color with 3:1 and 4.5:1 target ratios on base colors of pink, orange, and blue.

Steps to reproduce

  1. Create blue scale with colorKeys #B5D6FF, #57A5F5, #3D3AB0
  2. Select one of these base colors: #FFA751, #FF84E5, #54B8FF
  3. See returned white colors.

Expected behavior

Expect darker colors to be returned because darker shades of the variable color are still available.

Screenshots

This shot shows a pink hue returning dark blues. They are not yet black, and we see darker shades are still available for this variable color
Screen Shot 2019-12-18 at 8 22 43 AM

This shows the error -- slightly different pink base now returns white colors
Screen Shot 2019-12-18 at 8 22 57 AM

Environment

  • @leonardo-contrast-colors version: 1.0.0-alpha.2
  • Browser(s) and OS(s): Chrome Version 79.0.3945.79 on MacOS Mojave 10.14.6

Additional context