adobe/reactor-developer-docs

Adjust max width / right margin

Closed this issue · 4 comments

jeffchasin commented

Thoughts on changing

.sdldocs-components {
  flex: 1;
}

to

.sdldocs-components {
  flex-grow: .9;
  flex-shrink: inherit;
  flex-basis: 0;
}

Or whatever you prefer to basically add padding-right here in docs.css

remear commented

I'm not opposed to it. My only concern might be if it will look off-center. I've been wondering if it would make sense to limit the size of sdldocs-outer or the splitview and center it. Thoughts?

jeffchasin commented

Here's what I see locally currently:

Existing Layout

and with the tweak:

Proposed Layout

Since it's currently flex: 1, afaik in this layout the change should only affect the right side, leaving 10% (effective) "padding" but ¯_(ツ)_/¯

thebenrob commented

I like the idea of having some padding on the right side. 10% feels like a lot, but 5% might be fine.

remear commented

@jeffchasin Would you be interested in opening a pull request for this at 5%?

  • 👍1