TypeError: Can't instantiate abstract class SampleBasedDenoiserInterface with abstract methods training_step

[geyanjing]

When i use "make demo/train ",it shows the error.

[mgharbi]

This is due to breaking changes in the ttools library (https://github.com/mgharbi/ttools/blob/master/CHANGELOG.rst). Any 0.0.* version should work. I have changed the requirements in setup.py to fix this

sbmc/setup.py

Line 103 in dda096b

install_requires=["torch-tools==0.0.36", "bridson", "pandas", "pyexr",

[geyanjing]

Thanks very much!But there are some ConnectionError when i use the "make demo/train" in the docker container.

[mgharbi]

It looks like docker does not have access to your machine's port, but those should be opened by this command:

sbmc/Makefile

Line 52 in dda096b

-p 2001:2001 \

[mgharbi]

You should then be able to launch the visdom server using make server:

sbmc/Makefile

Line 176 in dda096b

server: