adonisjs/ally

Can't set additional parameter on baseUrl

rizalgunawan opened this issue · 1 comments

Hello, I plan to make a custom driver to login into Microsoft OAuth

Now, I want to setup baseUrl like this

get baseUrl() {
    return `https://login.microsoftonline.com/${this.tenantId}/oauth2/v2.0/`
}

I have set tenantId in constructor after super(config.clientId, config.clientSecret, config.headers)

this.tenantId = config.tenantId || 'common';

but it returned as undefined value

because of this
https://github.com/adonisjs/adonis-ally/blob/3c8697f7e0281f5ebe2903426a20c8bb8d24cace/src/Schemes/OAuth2.js#L99

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.