adopted-ember-addons/ember-set-helper

Typo in README?

Closed this issue · 2 comments

lljr commented

The README has a section that details differences with ember-set-helper. Should this be ember-simple-set-helper? Also, it says to install npm i ember-simple-set-helper, shouldn't it be npm i ember-set-helper? ember-simple-set-helper's page has the same instructions but does not matter because that's the package name for itself.

That said, is placeholder syntax removed in ember-set-helper?

@lljr - yes, all of these are typos, @pzuraq copied parts of the README from ember-simple-set-helper and that's why. You could submit a PR to fix those. 😃

The placeholder syntax has been removed, yes, but check out Setting Passed Values - that's what I used to convert my usages of the placeholder syntax.

lljr commented

@boris-petrov thanks. I'll send the PR