adoptium/aqa-tests

Update exclude_parser.py to error when ProblemList format has issues

jiekang opened this issue · 4 comments

jiekang commented

The exclude_parser.py runs as a GH action when changes are made to the ProblemList. It should error when issues with their syntax are found.

See also:
#5633
#5227

sophia-guo commented

Current the disableTestsLinter (pull_request) can detect the error but won't fail the check
Disabled Tests Linter / disableTestsLinter (pull_request) Successful in 14sdisable test won't fail the check https://github.com/adoptium/aqa-tests/actions/runs/11801561188/job/32875177726

sophia-guo commented

For extra space between os-arch, a simple check would be removing the maxsplit=2

aqa-tests/scripts/disabled_tests/exclude_parser.py

Line 116 in b7a3fba

split_line = test_excl.raw_line.split(maxsplit=2)

sophia-guo commented

We need to fail the github check process for all errors.

  • 👍1
smlambert commented

We want to make sure there are exactly 3 sections per line in a ProblemList file (each separated by a space)
Testclass | URL_to_open_issue | os-arch_comma-separatedList

and then verify that each has content that "looks right", which I thought the script already does (though perhaps not with the set of options we currently run it with)

  • 👍1