Rename local variable

Question

Rename local variable

gambledor opened this issue 11 years ago · 18 comments

MacVim 7.4
When I rename a local variable appears the dialog I write the new name inside it but the name is not changed.

Answer 1 · 2014-09-23T13:35:50.000Z

Hi could you give me an example of file where it doesn't work ? Also do you know the magic mode ?

Answer 2 · 2014-09-23T13:40:05.000Z

The file is your playground.php
I'm sorry but I do not know the magic mode; let me know how to enable it and I wll be glad to help you.

Answer 3 · 2014-09-23T14:45:19.000Z

Just by curiosity, did you try other refactoring ? Which variable did you try to rename ? Was it $renameMe ? I'll try to get my hands on a MacVim 7.4 to try it.

Answer 4 · 2014-09-23T14:54:40.000Z

Yes I did, the only one that doesn't work is this one.
I tried both variables $renameMe and $renameMeAlso

Answer 5 · 2014-09-23T15:07:37.000Z

Could you please try this command in your vim in the original playground file ?

:exec '16,21:s/$renameMe>/$foobar/ge'

Answer 6 · 2014-09-23T15:17:16.000Z

That command as is applies no change.
I reckon the problem could be in '>'; without it the substitution works even if not properly.

Answer 7 · 2014-09-23T15:49:48.000Z

Sorry I missed a char in my command. Could you run this one ?

:exec '16,21:s/$renameMe\>/$foobar/ge'

I tried this refactoring on Vim Mac 7.4 on a friends mac and I had no issue with it.

Answer 8 · 2014-09-23T15:51:53.000Z

Right, now it works

Answer 9 · 2014-09-23T15:59:42.000Z

Ok this is strange. This should be the exact same command executed in the refactoring.

Could you add this line on line 308 (after or before the exec) and run the refactoring again ? You should see the output on the bottom left.

echom l:startLine . ',' . l:stopLine . ':s/' . a:search . '/'. a:replace .'/ge'

Answer 10 · 2014-09-23T16:24:05.000Z

I put it before the exec
I restarted vim
I did the refactor and nothing shows up but ':call PhpRenameLocalVariable()'

Answer 11 · 2014-09-23T19:19:17.000Z

Could you use the version from the branch 1-Rename-local-variable
Or the file here : https://raw.githubusercontent.com/adoy/vim-php-refactoring-toolbox/1-Rename-local-variable/plugins/php-refactoring-toolbox.vim

And tell me if it's not working the output you get ?

Thanks a lot for your help

Answer 12 · 2014-09-24T15:14:54.000Z

Did you have the chance to try ?

Answer 13 · 2014-09-24T15:39:41.000Z

Hi, this is the output
16,21:s/$$renameMeAlso>/$testit/ge
we've got a '$' sign more

Answer 14 · 2014-09-24T15:53:36.000Z

Ok I see the problem. I'll have to look at how it's possible that expand('<cword>') on my vim return the variable without $ and your don't. I'll get back to you ASAP :-) Thanks

Answer 15 · 2014-09-24T16:06:18.000Z

Could you run this and tell me the output when you're in the playground.php file ?
:set iskeyword?

I suspect there is something in the keyword that differ in our instances

Answer 16 · 2014-09-24T16:14:27.000Z

Do you mean this?
iskeyword=@,48-57,_,192-255,$

Answer 17 · 2014-09-24T16:57:40.000Z

Ok thanks I know the problem now. You have $ in your keyword. I created a patch to make sure that $ is not included which should make both our config work.

Could you test the version here :

https://raw.githubusercontent.com/adoy/vim-php-refactoring-toolbox/1-Rename-local-variable/plugins/php-refactoring-toolbox.vim

Answer 18 · 2014-09-25T07:40:05.000Z

Ok, I state the last patch works for me too 👍