adoy/vim-php-refactoring-toolbox

Custom Visibility

jrean opened this issue · 1 comments

jrean commented

Hi,

Great plugin!

  • It would be great to allow one to set a custom visibility (private|protected|public|static|abstract) when adding and/or extracting a variable.
  • It would be great to allow one to set a custom visibility (private|protected|public|static|abstract) when extracting a selection to create a new method.

What do you think?

I sent you two pull requests for each case. I kept your default behaviour setting the variable and/or method as private.

#8
#9

:-)

adoy commented

Thanks for your contributions. I merged them and added few things.