adrian-goe/nx-aws-cdk-v2

Include @nx/devkit as a dependency

Opened this issue · 5 comments

isaacplmann commented

This plugin doesn't have an Nx version listed in the Nx Plugin Registry because the plugin doesn't include @nx/devkit as a dependency. Could you please release a version that fixes that?

Thanks,
Isaac (Nx Team)

adrian-goe commented

hey @isaacplmann I will do, but just to be sure, this goes into addDependenciesToPackageJson part as a dev dependency right?

teaforchris commented

I had a similar issue, I couldn't just run nx generate @ago-dev/nx-aws-cdk-v2:application myApp - I had to methodically retry and manually install several dependencies before it would generate the app:

@nx/devkit
@nx/jest
@nx/linter
nubunto commented

kinda unusable without this

thoroc commented

@isaacplmann could you answer the question? @adrian-goe might still be waiting for you.

isaacplmann commented

The easiest solution is to add the packages to the dependencies in https://github.com/adrian-goe/nx-aws-cdk-v2/blob/main/packages/aws-cdk-v2/package.json

You can put them in the dependencies or peerDependencies. devDependencies won't require the users of your package to have those packages installed.

I think that function is another way of adding the packages if you can't do it manually for some reason.

  • 👍1