adrienverge/PhotoCollage

Harmonize appearance of file chooser dialogs

Opened this issue · 4 comments

frankMilde commented

Nice and really useful software. This is just some feedback:

Maybe there is a specific rational behind the current status. However, the Add and Save file chooser dialogs could be improved by having the same appearance.

ATM, Add always opens with Recent and has no search bar.
add

Save always opens in the home dir showing a search bar, but has no Recent.
save

adrienverge commented

Hi @frankMilde,

I agree. Contributions are welcome! :)

frankMilde commented

@adrienverge I never did python before. Only c/c++, java and go.

I tried playing with the source. However, doing a python3 setup.py build never included my changes. I even deleted the content of the source files, rmed the __pycache__/ and build/ folder, but it would throw no compile error when running python3 setup.py build and i could execute the main script under bin/, which always fired up the original photocollage sans my changes.

Could you give me some pointers, what i am doing wrong here?

adrienverge commented

Hey @frankMilde,

Here is what you can do to get started: after playing with the source, run:

python3 -c 'from photocollage import gtkgui; gtkgui.main()'

or:

PYTHONPATH=. bin/photocollage

Calling bin/photocollage without PYTHONPATH will actually use the photocollage lib files in /usr/lib/, which are not the ones you modified.

I admit this is a bit tricky. ;-)
I'll try to write some instructions for contributors in the README file.

By the way, for information:

  • You don't need to python3 setup.py build unless you want to distribute the package to someone else or to a Linux distribution (which I'm already doing).
  • You usually don't need to remove __pycache__, because Python automatically updates the compiled files in it when you change the source.
frankMilde commented

Ahh yes. Thats it. Awesome. Now i can fiddle around. Nit that it will amount to much that is idiomatic python, but still. Thanks Adrien!