Enable ruff format?

Question

Enable ruff format?

Closed this issue 10 months ago · 7 comments

DimitriPapadopoulos commented a year ago

Answer 1 · 2024-01-08T09:38:23.000Z

To see how it formats Python source code, run:

ruff format .

Answer 2 · 2024-01-09T06:53:26.000Z

I'm -1 to change the current source code and alter Git history for 65 files and ~10k lines of code. Also I don't have a problem with currently-used single quotes or mixed indentation when it helps readability.

Answer 3 · 2024-01-09T09:27:01.000Z

Single quotes won't change:

ruff has always been supporting single quotes,
black started supporting them recently.

I haven't investigated indentation.

Answer 4 · 2024-01-09T09:35:58.000Z

While git blame --ignore-revs-file is not perfect, it helps ignore changes related to formatting.

Answer 5 · 2024-01-09T09:40:31.000Z

Let me run ruff format and try to minimize changes, so we can see the extent of changes.

Answer 6 · 2024-01-09T10:12:56.000Z

indent-style is either tab or space.

Answer 7 · 2024-01-13T06:37:34.000Z

Good that ruff supports mixed quotes 👍
I see all the changes in #638, and I still don't think it helps readability, especially about the mixed indentations I mentioned. And changing all these 63 files is not appealing...