adzerk-oss/boot-cljs-repl

Improve/standardize method used to compare versions

pkobrien opened this issue · 4 comments

If we need to compare versions of dependencies we should use goog.string.compareVersions.

http://google.github.io/closure-library/api/source/closure/goog/string/string.js.src.html#l1190

We need to compare versions in Clojure and that is a JS library.

Oops! You are totally correct. That's what I get for spending so much time in cljs-land. There is this library, but I don't know much about it: https://github.com/xsc/version-clj

We should probably think about including these utilities (no matter how they are implemented) in Boot. The tasks shouldn't depend on libraries directly but only through pods and using pods for version comparison would be quite overkill.

Will be unnecessary once we don't automatically add the dependencies but instead check if weasel or piggieback is available and tell user to manually add them to project if they are not.