aesara-devs/aeppl

Replace remaining docstring instances of `factorized_joint_logprob`

larryshamalama opened this issue · 4 comments

In #196, factorized_joint_logprob has been renamed to conditional_logprob. However, there are still some occurrences in docstrings where factorized_joint_logprob shows up:

aeppl/aeppl/abstract.py

Lines 80 to 82 in fb6ffc5

If `measurable_outputs_fn` isn't specified, a no-op is used; the result is
a clone of `node` that will effectively be ignored by
`factorized_joint_logprob`.

aeppl/aeppl/mixture.py

Lines 273 to 275 in 7890228

# We create custom types for the mixture components and assign them
# null `get_measurable_outputs` dispatches so that they aren't
# erroneously encountered in places like `factorized_joint_logprob`.

aeppl/tests/test_dist.py

Lines 412 to 413 in 696effa

def test_discrete_Markov_chain_factorized_logp():
"""Make sure that discrete Markov chains are picked up by `factorized_joint_logprob`.

Thanks for pointing that out!

Can I help in that @brandonwillard
Just give little detail of that. It will my first contro to open project

rlouf commented

Of course, you'll just have to replace the occurrences of factorized_joint_logprob with conditional_logprob. Open a PR and we can help you there if you need to.

rlouf commented

Closed by #233