2018.03: issue passing from tau_generator() to taus_valid1 when using octave for taus
Closed this issue · 4 comments
version 2018.03
issue: error passing from tau_generator() to taus_valid1 when using octave for taus, error free when passing decade as taus
log :
File "GT9000show.py", line 68, in dev
self.devs[devtype].compute(devtype)
File "D:\ffrank\Programmes\WinPython3.6.5.0\python-3.6.5.amd64\lib\site-packages\allantools\dataset.py", line 143, in compute
data_type=self.inp["data_type"], taus=self.inp["taus"])
File "D:\ffrank\Programmes\WinPython3.6.5.0\python-3.6.5.amd64\lib\site-packages\allantools\allantools.py", line 146, in tdev
(taus, md, mde, ns) = mdev(phase, rate=rate, taus=taus)
File "D:\ffrank\Programmes\WinPython3.6.5.0\python-3.6.5.amd64\lib\site-packages\allantools\allantools.py", line 197, in mdev
(phase, ms, taus_used) = tau_generator(phase, rate, taus=taus)
File "D:\ffrank\Programmes\WinPython3.6.5.0\python-3.6.5.amd64\lib\site-packages\allantools\allantools.py", line 1386, in tau_generator
taus_valid1 = taus < (1 / float(rate)) * float(len(data))
TypeError: '<' not supported between instances of 'numpy.ndarray' and 'float'
Seing that live with Florian. Weird thing is that this function is covered by tests (and passing them). It seems perfectly legit to use < to filter on numpy.ndarray objects. Perhaps a hint: he uses numpy 1.13.3 (in a winpython env) and I have 1.14.0 in ubuntu 17.10 (but it was probably working with 1.13.X anyway before…)
Travis-CI is now setup to run tests on Python 2.7, 3.4, and 3.5.
Maybe we can add 3.6 too, if that helps..
travis tests seem to run ok on py3.6
https://travis-ci.org/aewallin/allantools/jobs/394585882
no activity here for 12 months - closing. please resubmit if there still are problems.