SFDO-Community/declarative-lookup-rollup-summaries

Deploy Trigger not successful, with no error (due to code coverage being low)

BellasDad opened this issue · 6 comments

When I try to deploy a child trigger before activating a new summary, the deployment completes, but the code does not appear. No error message is generated, apex objects (Class and trigger) are not displayed, and button is not updated to Remove as expected.

image

This just started happening when "My Domain" was implemented. Was also getting the missing Remote site error, copying the remote site listed in the message cleared that error, but still can't deploy.

I know what this was caused by, the deploy did not have sufficient code coverage. Not sure if you can detect that, but it might be something for the enhancement list.

@jimrae Thanks for this, it sounds likely. The tricky thing for me is finding a true production org to reproduce this in, particularly one where i suspect environmental changes have caused previously deployed tests to cover the appropriate level of code. What I'll do is have a look through the code and error handling and see if i can make a speculative guess at what i might be missing, i'll let you know.

Hmmm... yes i see what i might be missing here... http://www.salesforce.com/us/developer/docs/api_meta/Content/meta_deploy.htm. RunTestsResult contains a codeCoverageWarnings property i should be checking in the RollController.cls method https://github.com/afawcett/declarative-lookup-rollup-summaries/blob/master/rolluptool/src/classes/RollupController.cls#L215.

Awesome, this is a great tool, glad I could contribute in some small way.

Thanks 👍 You certainly did, sometimes i get issues like this reported and folks move on before sharing if they gave up or found a solution, so your feedback is most definitely appreciated!

Issue fixed in v1.11 package.