BUG: existing user joining group with OAuth broken [3]

[hypernormal]

resolved by #669

---

Symptom 1

on joining a group (via google or fbook OAuth) as a user who already exists in affinity (as determined by email address match), and then entering a phone number that already exists in the DB, the page:

• will not submit
• shows confusing error messages referring to fields that were not previously there
• shows fields that were not previously on the page
• mangles styling for all fields

Symptom 2

• on re-joining a group (via google or fbook OAuth) as a user who has already joined the group, after completing step 2 the page:
• will not submit
• shows confusing error messages about pre-existing memberships
• mangles styling for all fields

Implementation Notes

• the field styling is due to the fact that we are recyclying the _error_alerts partial from members/new without accounting for the fact that we are handling several fields on @member as hidden fields that the partial expects to be part of the form
• the errors themselves could be avoided by checking for pre-existing members either before or after hitting step 2

[hypernormal]

[aguestuser]

@Matt-Holland this could still use manual testing.

it has been merged into https://staging.affinity.works

instructions for manual testing can be found in #669