Wrong command in .pokemon-icat.sh

Question

Wrong command in .pokemon-icat.sh

Sommerrolle opened this issue a year ago · 4 comments

This command in line 14 of file pokemon-icat.sh did not work for me:
kitten icat --align left --silent $HOME/.pokemon-icat/pokemon-icons/$pokemon.png

I changed it to
kitty +kitten icat --align left --silent $HOME/.pokemon-icat/pokemon-icons/$pokemon.png

I don't know is this is a change from the kitty terminal itself. Just wanted to mention it if someone else had a similar problem :)

Answer 1 · 2023-09-06T14:20:23.000Z

kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well.

Answer 2 · 2023-09-06T15:26:42.000Z

kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well.

so, do you suggest me to change that line to make sure it works on older versions as well?

Answer 3 · 2023-09-06T16:03:00.000Z

On Wed, Sep 06, 2023 at 08:26:53AM -0700, Alessio Bandiera wrote: > kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well. so, do you suggest me to change that line to make sure it works on older versions as well?

It's a bit slower as kitty +kitten icat will end up calling kitten icat but not significantly, so its up to you if the tradeoff is worth it.

Answer 4 · 2023-09-06T16:12:33.000Z

On Wed, Sep 06, 2023 at 08:26:53AM -0700, Alessio Bandiera wrote: > kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well. so, do you suggest me to change that line to make sure it works on older versions as well?
It's a bit slower as kitty +kitten icat will end up calling kitten icat but not significantly, so its up to you if the tradeoff is worth it.

ok, thank you!