agenda/agendash

V2 release plan

Closed this issue · 5 comments

simison commented
  • Merge PR: #135
  • Remove explicit Hapi/Express dependency and add instructions how to add either one of those. #136
  • Fix broken HAPI test #138
  • Fix broken Express test #139
  • Fix tests/linter and get Travis CI green
  • Ensure @santiq has all the rights to this repo & NPM org
  • Release this to NPM as 2.0.0
  • Update Agenda Readme
  • Mark agendash2 NPM package as deprecated
  • Close old issues and PRs in this repo (@santiq up for the task? 😅 )
  • Transfer issues from agendash2 to this repo
  • Denote agendash2 as deprecated in Github repo Readme and mark repo archived
simison commented

A few todos/thoughts —

  • publish/version automation feels a bit much for my taste — I like to just have these manual so that it does what I expect it to do and I can avoid mistakes:

    agendash/package.json

    Lines 10 to 12 in ed737ab

    "scripts": {
    "postversion": "npm publish",
    "postpublish": "git push origin --all; git push origin --tags",

  • It might be easier to update dependencies if CDN stuff would just be in package.json and bundled? Update: actually not necessarily

    agendash/public/index.html

    Lines 15 to 28 in ed737ab

    <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
    integrity="sha384-Vkoo8x4CGsO3+Hhxv8T/Q5PaXtkKtu6ug5TOeNV6gBiFeWPGFN9MuhOf23Q9Ifjh" crossorigin="anonymous">
    <script src="https://code.jquery.com/jquery-3.4.1.slim.min.js"
    integrity="sha384-J6qa4849blE2+poT4WnyKhv5vZF5SrPo0iEjwBvKU7imGFAV0wwj1yYfoRSJoZ+n" crossorigin="anonymous"></script>
    <script src="https://cdn.jsdelivr.net/npm/popper.js@1.16.0/dist/umd/popper.min.js"
    integrity="sha384-Q6E9RHvbIyZFJoft+2mJbHaEWldlvI9IOYy5n3zV9zzTtmI3UksdQRVvoxMfooAo" crossorigin="anonymous"></script>
    <script src="https://stackpath.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"
    integrity="sha384-wfSDF2E50Y2D1uUdj0O3uMBJnjuUD4Ih7YwaYd1iqfktj0Uod8GCExl3Og8ifwB6" crossorigin="anonymous"></script>
    <link href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;1,300;1,400;1,500;1,900&display=swap" rel="stylesheet">
    <link href="https://fonts.googleapis.com/css2?family=Days+One&display=swap" rel="stylesheet">
    <link href="https://fonts.googleapis.com/icon?family=Material+Icons"
    rel="stylesheet">
    <link href="https://cdn.jsdelivr.net/npm/prismjs@1.20.0/themes/prism.css" rel="stylesheet" />
    <link rel="stylesheet" href="https://unpkg.com/vue-prism-editor@0.6.1/dist/VuePrismEditor.css">

  • Dockerfile looks like it needs an update. PR #142

  • Some agendash-v2 and Agenda 2 in public/index.html and in public/app/js/main.js

  • I don't see "made with..." appear anywhere — perhaps we could remove it and just consider this be from "Agenda contributors"? :-)

    agendash/public/app/js/main.js

    Line 226 in 790f35a

    <small>Made with ❤ by <a class="text-light" href="https://www.softwareontheroad.com/about" target="_BLANK">Software On The Road</a></small>

koresar commented

I believe we should leave link to Sam Quinn. So, it looks like this now:

UI written by Sam Quinn. Backend by Agenda team.

koresar commented

@simison I've checked all the boxes I've implemented today. Please, feel free to proceed with the release.

  • 👍1
koresar commented

@simison Can you please publish the Agendash v2?

koresar commented

All is done.

Except 1 thing - deprecating agendash2 in NPM registry. @santiq you are the only person who can do that.

  • 🚀1